From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v8 3/5] net: add a helper for making RARP packet Date: Tue, 09 Jan 2018 14:48:45 +0100 Message-ID: <3112517.GnCYoIETns@xps> References: <20180109142651.84582-4-xiao.w.wang@intel.com> <20180109132654.3504-1-xiao.w.wang@intel.com> <20180109132654.3504-4-xiao.w.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: yliu@fridaylinux.org, tiwei.bie@intel.com, dev@dpdk.org, stephen@networkplumber.org To: Xiao Wang Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 74EC71B1CF for ; Tue, 9 Jan 2018 14:49:10 +0100 (CET) In-Reply-To: <20180109132654.3504-4-xiao.w.wang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/01/2018 14:26, Xiao Wang: > +/** > + * Make a RARP packet based on MAC addr. > + * > + * @param mbuf > + * Pointer to the rte_mbuf structure > + * @param mac > + * Pointer to the MAC addr > + * > + * @return > + * - 0 on success, negative on error > + */ > +int > +rte_net_make_rarp_packet(struct rte_mbuf *mbuf, const struct ether_addr *mac); I think we should apply the new policy of introducting functions with the experimental state.