From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 1/2] net/i40e: support VF request more
 queues
Date: Mon, 17 Dec 2018 14:31:22 +0000
Message-ID: <3118a72e-409e-8048-55c6-a8a602525c21@intel.com>
References: <20181214143720.34163-1-zhirun.yan@intel.com>
 <20181217111054.45414-1-zhirun.yan@intel.com>
 <20181217111054.45414-2-zhirun.yan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Haiyue Wang <haiyue.wang@intel.com>
To: Zhirun Yan <zhirun.yan@intel.com>, dev@dpdk.org, qi.z.zhang@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id A25131B76F
 for <dev@dpdk.org>; Mon, 17 Dec 2018 15:31:25 +0100 (CET)
In-Reply-To: <20181217111054.45414-2-zhirun.yan@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/17/2018 11:10 AM, Zhirun Yan wrote:
> Before this patch, VF gets a default number of queues from the PF.
> This patch enables VF to request a different number. When VF configures
> more queues, it will send VIRTCHNL_OP_REQUEST_QUEUES to PF to request
> more queues, if success, PF will reset the VF.
> 
> User can run "port stop all", "port config port_id rxq/txq queue_num"
> and "port start all" to reconfigure queue number.
> 
> Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>

<...>

> @@ -359,6 +359,25 @@ i40evf_execute_vf_cmd(struct rte_eth_dev *dev, struct vf_cmd_info *args)
>  		} while (i++ < MAX_TRY_TIMES);
>  		_clear_cmd(vf);
>  		break;
> +	case VIRTCHNL_OP_REQUEST_QUEUES:
> +		 /*ignore async reply, only wait for system message,*/
> +		 /*vf_reset = true if get VIRTCHNL_EVENT_RESET_IMPENDING,*/
> +		 /*if not, means request queues failed */

Don't need comment terminators for each line, can have block comment, would you
mind if I fix while merging?