From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3] mempool: rename functions with confusing
	names
Date: Fri, 01 Jul 2016 12:21:17 +0200
Message-ID: <3129755.jsp6WimcDp@xps13>
References: <1467208504-13029-1-git-send-email-bruce.richardson@intel.com>
 <1613474.aBI9rN0qDz@xps13> <3fc02727-50d2-a6b6-8dcc-8c8d6a0b1d89@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Olivier MATZ <olivier.matz@6wind.com>, dev@dpdk.org, keith.wiles@intel.com,
 Panu Matilainen <pmatilai@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id 89F6E2BA8
 for <dev@dpdk.org>; Fri,  1 Jul 2016 12:21:19 +0200 (CEST)
Received: by mail-wm0-f44.google.com with SMTP id a66so22699205wme.0
 for <dev@dpdk.org>; Fri, 01 Jul 2016 03:21:19 -0700 (PDT)
In-Reply-To: <3fc02727-50d2-a6b6-8dcc-8c8d6a0b1d89@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-07-01 10:57, Olivier MATZ:
> 
> On 06/30/2016 10:05 PM, Thomas Monjalon wrote:
> > 2016-06-30 13:49, Bruce Richardson:
> >> The mempool_count and mempool_free_count behaved contrary to what their
> >> names suggested. The free_count function actually returned the number of
> >> elements that were allocated from the pool, not the number unallocated as
> >> the name implied.
> >>
> >> Fix this by introducing two new functions to replace the old ones,
> >> * rte_mempool_avail_count to replace rte_mempool_count
> >> * rte_mempool_in_use_count to replace rte_mempool_free_count
> >>
> >> In this patch, the new functions are added, and the old ones are marked
> >> as deprecated. All apps and examples that use the old functions are
> >> updated to use the new functions.
> > 
> > The ThunderX driver uses rte_mempool_count and needs an update.
> > Except that, it looks good.
> > 
> 
> Yep, I don't see any other issue.

Applied with ThunderX update, thanks