From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH] net/vhost: convert to new Rx offload API Date: Tue, 22 May 2018 14:12:36 +0200 Message-ID: <313c5cfe-f3d1-5003-48fa-271b6b29ec15@redhat.com> References: <20180522113639.32233-1-maxime.coquelin@redhat.com> <20180522115357.GA24273@debian> <20180522120937.GA26211@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, ferruh.yigit@intel.com To: Tiwei Bie Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id C39E51F1C for ; Tue, 22 May 2018 14:12:38 +0200 (CEST) In-Reply-To: <20180522120937.GA26211@debian> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/22/2018 02:09 PM, Tiwei Bie wrote: > On Tue, May 22, 2018 at 07:53:57PM +0800, Tiwei Bie wrote: >> On Tue, May 22, 2018 at 01:36:39PM +0200, Maxime Coquelin wrote: >>> Signed-off-by: Maxime Coquelin >>> --- >>> drivers/net/vhost/rte_eth_vhost.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c >>> index f473bbbb3..aadb2327c 100644 >>> --- a/drivers/net/vhost/rte_eth_vhost.c >>> +++ b/drivers/net/vhost/rte_eth_vhost.c >>> @@ -491,9 +491,9 @@ eth_dev_configure(struct rte_eth_dev *dev __rte_unused) >>> struct pmd_internal *internal = dev->data->dev_private; >>> const struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; >>> >>> - internal->vlan_strip = rxmode->hw_vlan_strip; >>> + internal->vlan_strip = !!(rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP); >>> >>> - if (rxmode->hw_vlan_filter) >>> + if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER) >>> VHOST_LOG(WARNING, >>> "vhost(%s): vlan filtering not available\n", >>> internal->dev_name); >> >> To better align with the new offload API, I think we >> also need to announce those features in dev_infos_get. I'm looking at it, and agree we have to announce support for these offload features. > I mean offloads (I'm too used to say features recently...). > Besides, maybe we can also take this chance to announce the > DEV_TX_OFFLOAD_MULTI_SEGS offload. How do you think? Yes, and also DEV_TX_OFFLOAD_VLANiINSERT. Right? > Best regards, > Tiwei Bie >