From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy
Date: Fri, 13 Oct 2017 11:28:44 +0200
Message-ID: <31420042.6nB00FbIV6@xps>
References: <1507206794-79941-1-git-send-email-xiaoyun.li@intel.com>
 <1507885309-165144-1-git-send-email-xiaoyun.li@intel.com>
 <1507885309-165144-2-git-send-email-xiaoyun.li@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, bruce.richardson@intel.com, wenzhuo.lu@intel.com,
 helin.zhang@intel.com
To: Xiaoyun Li <xiaoyun.li@intel.com>, konstantin.ananyev@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id EF9971B676
 for <dev@dpdk.org>; Fri, 13 Oct 2017 11:28:45 +0200 (CEST)
In-Reply-To: <1507885309-165144-2-git-send-email-xiaoyun.li@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

13/10/2017 11:01, Xiaoyun Li:
>  lib/librte_eal/common/arch/x86/rte_memcpy.c        |  59 ++
>  lib/librte_eal/common/arch/x86/rte_memcpy_avx2.c   |  44 +
>  .../common/arch/x86/rte_memcpy_avx512f.c           |  44 +
>  lib/librte_eal/common/arch/x86/rte_memcpy_sse.c    |  40 +
>  .../common/include/arch/x86/rte_memcpy.h           | 861 +-----------------
>  .../common/include/arch/x86/rte_memcpy_internal.h  | 966 +++++++++++++++++++++

I think that rte_memcpy_internal.h should not be in the include directory.
Can it be moved to lib/librte_eal/common/arch/ ?

> --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
> +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
> @@ -243,6 +243,7 @@ DPDK_17.11 {
>  	rte_eal_iova_mode;
>  	rte_eal_mbuf_default_mempool_ops;
>  	rte_lcore_has_role;
> +	rte_memcpy_ptr;

I don't know what is the consequence of adding this function in the .map
file for architectures where it does not exist?