From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 5/9] librte_ether:add data structures of VxLAN filter Date: Wed, 22 Oct 2014 11:25:06 +0200 Message-ID: <3142740.MjSjxYyKcT@xps13> References: <1413881168-20239-1-git-send-email-jijiang.liu@intel.com> <1893361.J7EnPDFulE@xps13> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D828AA@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Liu, Jijiang" Return-path: In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D828AA-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-10-22 06:45, Liu, Jijiang: > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > > 2014-10-21 16:46, Jijiang Liu: > > > +#define RTE_TUNNEL_FILTER_TO_QUEUE 1 /**< point to an queue by filter > > type */ > > > > Sorry, I don't understand what is this value for? > > This MACRO is used to indicate if user application hope to filter > incoming packet(s) to a specific queue(multi-queue configuration > is required) using filter type(such as inner MAC + tenant ID). > If the flag is not set, and all incoming packet will always go > to queue 0. 1) It's a boolean, so a new constant is not required. 2) You set the variable "to_queue" with this value but the variable is not used 3) Is there a sense to add a filter with this variable to 0? I think "to_queue" variable and this constant are useless. PS: it seems I'm the only person worried by the filtering API. So maybe we shouldn't integrate it at all? -- Thomas