From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 3/8] drivers/net/e1000: Fix missing brackets Date: Tue, 22 Mar 2016 21:06:58 +0100 Message-ID: <3160638.7nQCDhkLkr@xps13> References: <1456426121-21423-1-git-send-email-aconole@redhat.com> <56D576C7.9060108@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Panu Matilainen , "Lu, Wenzhuo" , dev@dpdk.org, Bruce Richardson To: Aaron Conole Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 2A81A2BA0 for ; Tue, 22 Mar 2016 21:08:39 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id r129so109241009wmr.1 for ; Tue, 22 Mar 2016 13:08:39 -0700 (PDT) In-Reply-To: <56D576C7.9060108@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-01 13:02, Panu Matilainen: > On 02/26/2016 03:13 PM, Aaron Conole wrote: > > "Lu, Wenzhuo" writes: > >> Normally we will not maintain the base code. It's just taken from kernel driver. > >> Agree with you that the whitespace is misleading. But as it's no real > >> impact. I'd like to say not a big deal, better not change it. :) > > > > Thanks for this hint. It turns out my patch is wrong. It should actually > > be this (and I've confirmed by looking at the drivers): [...] > > I will cook up a v2 of this patch if it makes sense. It is a real bug, > > so should be fixed. Yes, waiting for your v2. > Yes, it quite clearly is a real bug and there needs to be a documented > way of getting these things fixed. The README in the base/ directory is > not particularly helpful, since it only says "dont touch it". Yes don't touch it ;) > This is apparently fixed in FreeBSD codebase so fixing it would be > "just" a matter of pulling in a newer version. Probably. > The other alternatives are either disabling the whole driver in gcc 6 > builds, or paper over the bug with warning disablers, or have everybody > patch their packages locally to fix it, all of which just feel so stupid > they're not alternatives, really. No they are not sane alternatives. > OTOH the bug has been there for 2.5 years (since commit > 38db3f7f50bde45477f564783a06ac8fbd3348fa) and nobody has noticed... > > Thomas, Bruce, thoughts/comments? It is in the hands of Wenzhuo, the e1000 maintainer. You just need his ack.