From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] config: remove useless lines for DPAA2
Date: Tue, 03 Apr 2018 09:03:58 +0200
Message-ID: <3161325.7B0DNJKXUk@xps>
References: <20180402220649.662-1-thomas@monjalon.net>
 <5df8c54e-a750-e576-9adb-50ff863872d3@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: hemant.agrawal@nxp.com, dev@dpdk.org
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 007C41B675
 for <dev@dpdk.org>; Tue,  3 Apr 2018 09:35:06 +0200 (CEST)
In-Reply-To: <5df8c54e-a750-e576-9adb-50ff863872d3@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

03/04/2018 08:55, Shreyansh Jain:
> On Tuesday 03 April 2018 03:36 AM, Thomas Monjalon wrote:
> > Some comments are not relevant in a config which only overrides
> > the default config.
> > 
> > The option CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER is already disabled
> > by default so it can be removed from this file.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> >   config/defconfig_arm64-dpaa2-linuxapp-gcc | 7 -------
> >   1 file changed, 7 deletions(-)
> 
> I think DEBUG_DRIVER should exist in local config so that a developer 
> can easily toggle it without modifying the common_base, which should 
> serves as repository rather than toggle.

No, the file to be modified is .config in the build directory,
not the default config.

> I do see the problem that having an option in common_base and then 
> having it again in local config without overriding (=n) - is non-intuitive.
> 
> But, I still feel it is easier to control changes in local config - 
> (make T=<local config>) is easily visible.

It is not a local config file.
The local config is .config.