From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v5 6/6] eal: ignore messages until init is complete Date: Mon, 12 Mar 2018 08:58:00 +0000 Message-ID: <31652ac7-5951-a358-18df-2eb87c5abce8@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: keith.wiles@intel.com, konstantin.ananyev@intel.com To: "Tan, Jianfeng" , dev@dpdk.org Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 74BE519F5 for ; Mon, 12 Mar 2018 09:58:05 +0100 (CET) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12-Mar-18 1:42 AM, Tan, Jianfeng wrote: > > On 3/8/2018 12:56 AM, Anatoly Burakov wrote: >> If we receive messages that don't have a callback registered for >> them, and we haven't finished initialization yet, it can be reasonably >> inferred that we shouldn't have gotten the message in the first >> place. Therefore, send requester a special message telling them to >> ignore response to this request, as if this process wasn't there. > > Two nits: > - I think we could add a note in commit log that "it only applies to > primary to secondary request". > - To make the change more simple, maybe we can just put a declaration of > function mp_send. > >> Signed-off-by: Anatoly Burakov > > Acked-by: Jianfeng Tan > Makes sense, will do for v6. Thanks for the reviews! -- Thanks, Anatoly