From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radu Nicolau <radu.nicolau@intel.com>
Subject: Re: [PATCH 1/2] ethdev: add support for raw flow type
 for flow director
Date: Mon, 4 Sep 2017 11:35:37 +0100
Message-ID: <31727283-632e-ea3e-edbc-be1e6980be07@intel.com>
References: <1503588634-85735-1-git-send-email-kirill.rybalchenko@intel.com>
 <1503588634-85735-2-git-send-email-kirill.rybalchenko@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: andrey.chilikin@intel.com, beilei.xing@intel.com
To: Kirill Rybalchenko <kirill.rybalchenko@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 0F3CD7CA9
 for <dev@dpdk.org>; Mon,  4 Sep 2017 12:35:39 +0200 (CEST)
In-Reply-To: <1503588634-85735-2-git-send-email-kirill.rybalchenko@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 8/24/2017 4:30 PM, Kirill Rybalchenko wrote:
> Add new structure rte_eth_raw_flow to the union rte_eth_fdir_flow
> to support filter for raw flow type
>
> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> ---
>   lib/librte_ether/rte_eth_ctrl.h | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/librte_ether/rte_eth_ctrl.h
> index 8386904..22d9640 100644
> --- a/lib/librte_ether/rte_eth_ctrl.h
> +++ b/lib/librte_ether/rte_eth_ctrl.h
> @@ -525,6 +525,15 @@ struct rte_eth_tunnel_flow {
>   };
>   
>   /**
> + * A structure used to define the input for raw flow
> + */
> +struct rte_eth_raw_flow {
> +	uint16_t flow; /**< flow type. */
> +	void *packet; /**< pre-constructed packet buffer. */
> +	uint16_t length; /**< buffer length. */
> +};
Nitpicking on comments alignment.
> +
> +/**
>    * An union contains the inputs for all types of flow
>    * Items in flows need to be in big endian
>    */
> @@ -540,6 +549,7 @@ union rte_eth_fdir_flow {
>   	struct rte_eth_ipv6_flow   ipv6_flow;
>   	struct rte_eth_mac_vlan_flow mac_vlan_flow;
>   	struct rte_eth_tunnel_flow   tunnel_flow;
> +	struct rte_eth_raw_flow    raw_flow;
>   };
>   
>   /**