From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] net/virtio: fix crash on null dereference Date: Fri, 22 Jul 2016 00:31:08 +0200 Message-ID: <31963607.SkieP2J2tS@xps13> References: <95aa6068-2444-304e-2dc1-ff1975f6132a@6wind.com> <1468895993-3292-1-git-send-email-yuanhan.liu@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Yuanhan Liu Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 901925679 for ; Fri, 22 Jul 2016 00:31:10 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id q128so36647707wma.1 for ; Thu, 21 Jul 2016 15:31:10 -0700 (PDT) In-Reply-To: <1468895993-3292-1-git-send-email-yuanhan.liu@linux.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-07-19 10:39, Yuanhan Liu: > The rxq/txq for the queue_release callback could be NULL, say when > rte_eth_dev_configure() fails that the queue is not setup at all. > > Do a simple NULL check would fix the crash issue. > > Fixes: 01ad44fd374f ("net/virtio: split Rx/Tx queue") > > Reported-by: Olivier Matz > Signed-off-by: Yuanhan Liu Applied, thanks