From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 3/6] net/tap: check interface name in kvargs
Date: Tue, 15 Jan 2019 03:01:25 +0100
Message-ID: <3206134.sXzW2Za7dA@xps>
References: <20190111180659.5972-1-stephen@networkplumber.org>
 <20190111114917.06da84bb@hermes.lan>
 <832D25F2-DEC4-4404-8A9F-4043D7609936@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Wiles, Keith" <keith.wiles@intel.com>,
 Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D7DFFD0B2
 for <dev@dpdk.org>; Tue, 15 Jan 2019 03:01:28 +0100 (CET)
In-Reply-To: <832D25F2-DEC4-4404-8A9F-4043D7609936@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

11/01/2019 20:50, Wiles, Keith:
> 
> > On Jan 11, 2019, at 1:49 PM, Stephen Hemminger <stephen@networkplumber.org> wrote:
> > 
> > On Fri, 11 Jan 2019 19:37:00 +0000
> > "Wiles, Keith" <keith.wiles@intel.com> wrote:
> > 
> >>> +/* make sure name is a possible Linux network device name */
> >>> +static bool is_valid_iface(const char *name)  
> >> 
> >> I am sorry, but the function name must be on the next line as per the style. I know you do not like it, but that is what the style states.
> > 
> > I am surprised because most of the DPDK follows kernel style.
> > And in kernel style one line is preferred if line is not too long.
> 
> Last time I looked at the DPDK coding style it is not the case. We do not really follow Linux coding style only started with it and made changes :-(

Not really. The original code style is borrowed from FreeBSD:
	https://www.freebsd.org/cgi/man.cgi?query=style&sektion=9