From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 3/7] drivers/net/bnxt new driver for
	Broadcom bnxt
Date: Thu, 21 Apr 2016 12:11:33 +0200
Message-ID: <3207073.5iacktQG42@xps13>
References: <1456978137-98097-1-git-send-email-stephen.hurd@broadcom.com>
 <CAJ9nmBbrt3Rp21vCWvHi8drMtvytO6iR+rEqpF1M6BBcKPABVA@mail.gmail.com>
 <20160421100005.GA976@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>,
 Stephen Hurd <stephen.hurd@broadcom.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id DD1F12C17
 for <dev@dpdk.org>; Thu, 21 Apr 2016 12:11:54 +0200 (CEST)
Received: by mail-wm0-f47.google.com with SMTP id n3so124614278wmn.0
 for <dev@dpdk.org>; Thu, 21 Apr 2016 03:11:54 -0700 (PDT)
In-Reply-To: <20160421100005.GA976@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-04-21 11:00, Bruce Richardson:
> On Wed, Apr 20, 2016 at 02:32:18PM -0700, Stephen Hurd wrote:
> > > It's not for testing, more for code review and to help understand the code
> > > [though
> > > as you say, we do need to ensure that each commit doesn't actually break
> > > the
> > > build].
> > > Right now, the driver code goes in as a single commit - which makes it a
> > > hard
> > > enough task to review and see what is in there. One suggestion that
> > > hopefully
> > > wouldn't be too much work might be to split the code up into: basic device
> > > init code, RX and TX functions, and then any additional features based on
> > > top
> > > of that [ideally one patch per added feature].
> > >
> > 
> > The current driver doesn't have much beyond basic TX/RX, but we can give it
> > a shot.  "Too much work" is relative of course, but splitting it into
> > self-contained easily understood chunks will absolutely be a lot of work.
> > 
> > Adding Ajit who will also be working on this.  Since he's coming up to
> > speed on the driver code, this could be a good way for him to fully
> > familiarize himself with it.
> > 
> Sure, thanks. Any splitting you can do at all would be appreciated and help with
> reviews.

I'd add that it helps newcomers to understand the driver by reading the
git history.
Thanks