From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mem: warn if address hint is not respected Date: Fri, 12 Jan 2018 00:36:14 +0100 Message-ID: <3211441.Y6Jkbn8iFl@xps> References: <1509440909-8068-1-git-send-email-jpf@zurich.ibm.com> <10656029.OGFJoE0f1c@xps> <55afaf0a-14cc-11b0-c7ec-21ea1bc2403f@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Burakov, Anatoly" , jianfeng.tan@intel.com To: Jonas Pfefferle Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5578144BE for ; Fri, 12 Jan 2018 00:36:43 +0100 (CET) In-Reply-To: <55afaf0a-14cc-11b0-c7ec-21ea1bc2403f@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/11/2017 14:54, Burakov, Anatoly: > On 06-Nov-17 8:26 PM, Thomas Monjalon wrote: > > 31/10/2017 10:08, Jonas Pfefferle: > >> Print a warning if the --base-virtaddr hint is not respected > >> since this might lead to problems when mapping memory in > >> the secondary process. > >> > >> Signed-off-by: Jonas Pfefferle > > > > Anatoly, please review this patch. > > It does not seem to fix something, so it is candidate for 18.02. > > > > For some reason my Thunderbird ate the original email, so i'll reply to > this one. > > One nitpick would be that we're calling get_virtual_area many times and > it would probably be a good idea to make pagesize static and call > sysconf only once. Otherwise, > > Acked-by: Anatoly Burakov Applied, thanks