From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v4 1/8] rte: change xstats to use integer ids
Date: Wed, 15 Jun 2016 11:19:47 +0200
Message-ID: <3213969.ZfC4lDELmR@xps13>
References: <1465833121-26953-1-git-send-email-remy.horton@intel.com>
 <1465833121-26953-2-git-send-email-remy.horton@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Remy Horton <remy.horton@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 8DBCBC40C
 for <dev@dpdk.org>; Wed, 15 Jun 2016 11:19:49 +0200 (CEST)
Received: by mail-wm0-f45.google.com with SMTP id a66so14678982wme.0
 for <dev@dpdk.org>; Wed, 15 Jun 2016 02:19:49 -0700 (PDT)
In-Reply-To: <1465833121-26953-2-git-send-email-remy.horton@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-06-13 16:51, Remy Horton:
> Signed-off-by: Remy Horton <remy.horton@intel.com>

Please insert an explanation of why this change is needed.

[...]
>  /**
> + * Retrieve names of extended statistics of an Ethernet device.
> + *
> + * @param port_id
> + *   The port identifier of the Ethernet device.
> + * @param xstats_names
> + *  Block of memory to insert names into. Must be at least size in capacity.
> + *  If set to NULL, function returns required capacity.
> + * @param size
> + *  Capacity of xstats_names (number of names).
> + * @return
> + *  If successful, number of statistics; negative on error.
> + */

Like in rte_eth_xstats_get(), it should return a positive value if size
is not big enough.

> +int rte_eth_xstats_get_names(uint8_t port_id,
> +		struct rte_eth_xstat_name *xstats_names,
> +		unsigned size);

[...]
> +DPDK_16.07 {
> +	global:
> +
> +	rte_eth_xstats_names;
> +	rte_eth_xstats_count;
> +} DPDK_16.04;

Wrong functions.