From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] test_mempool: remove unused mp_ext var
Date: Thu, 21 Jul 2016 23:57:26 +0200
Message-ID: <3219554.rj5DkKP6AW@xps13>
References: <1469101787-7186-1-git-send-email-santosh.shukla@caviumnetworks.com>
 <887a9e8d-b7cf-4148-d749-5019b206405e@6wind.com> <24109515.NGORzl0sje@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org,
 David Hunt <david.hunt@intel.com>
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id 769D2559C
 for <dev@dpdk.org>; Thu, 21 Jul 2016 23:57:28 +0200 (CEST)
Received: by mail-wm0-f43.google.com with SMTP id q128so35981985wma.1
 for <dev@dpdk.org>; Thu, 21 Jul 2016 14:57:28 -0700 (PDT)
In-Reply-To: <24109515.NGORzl0sje@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-07-21 15:35, Thomas Monjalon:
> 2016-07-21 15:28, Olivier Matz:
> > Hi Santosh,
> > 
> > On 07/21/2016 01:49 PM, Santosh Shukla wrote:
> > > test_mempool func not using pointer variable 'mp_ext' and incorrectly freed. So
> > > removing ptr var. Now freeing mp_stack var.
> > > 
> > > Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> > 
> > Strange, it seems these modifications were present in latest patch from
> > David Hunt (v6). Maybe a bad manipulation during the push?
> 
> Yes sorry, it seems to be a wrong manipulation, the v5 was pushed.
> This patch seems to fix my error, thanks.
> 
> > The "Fixes:" line should be added though.

Fixes: ea151eb48a04 ("app/test: migrate custom mempool handler to stack handler")

> > Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks