From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] mk: Only default to -Werror when building from git checkout Date: Sat, 21 Feb 2015 11:48:03 +0100 Message-ID: <3223516.n06PbLjW1e@xps13> References: <54DCB16F.7080104@redhat.com> <9190554.3JBlDK3N1R@xps13> <20150220181540.3b97dc86@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Stephen Hemminger Return-path: In-Reply-To: <20150220181540.3b97dc86@urahara> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-02-20 18:15, Stephen Hemminger: > On Fri, 20 Feb 2015 13:15:38 +0100 > Thomas Monjalon wrote: > > > 2015-02-12 17:18, Panu Matilainen: > > > Add RTE_DEVEL_BUILD make-variable which can be used to do things > > > differently when doing development vs building a release, > > > autodetected from source root .git presence and overridable via > > > commandline. Use it to only enable -Werror compiler flag when > > > building a git checkout: > > > > > > Failing build on warnings is a useful developer tool but its bad > > > for release tarballs which can and do get built with newer > > > compilers than what was used/available during development. Compilers > > > routinely add new warnings so code which built silently with cc X > > > might no longer do so with X+1. This doesn't make the existing code > > > any more buggier and failing the build in this case does not help > > > not help improve code quality of an already released version either. > > > > Please, could you update documentation to explain RTE_DEVEL_BUILD option? > > Some users could try to build from git, so we should advise to disable RTE_DEVEL_BUILD. > > These files might be updated: > > http://dpdk.org/browse/dpdk/tree/doc/build-sdk-quick.txt > > http://dpdk.org/browse/dpdk/tree/doc/guides/linux_gsg/build_dpdk.rst > > http://dpdk.org/browse/dpdk/tree/doc/guides/freebsd_gsg/build_dpdk.rst > > http://dpdk.org/browse/dpdk/tree/doc/guides/prog_guide/dev_kit_build_system.rst > > > > Thanks > > Also do not allow any patches to into upstream that cause > new warnings with latest stable version of Gcc or Clang? > I don't want a clean project to get littered with warning graffiti. > Maybe a build bot? Yes there are some daily builds with many compilers/distros. We'll have to be sure that they are done in devel mode (with -Werror). Anyway devel build is a sanity check which should be done by every developers and reviewers.