From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v5 0/3] security: support for pdcp
Date: Thu, 18 Oct 2018 16:40:11 +0200
Message-ID: <3236120.8JxESPyN3M@xps>
References: <20181015124858.5562-1-akhil.goyal@nxp.com>
 <20181016103352.2678-1-akhil.goyal@nxp.com>
 <cacde6d7-06c4-e77a-e887-e4485547ef24@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org,
 "pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
 "radu.nicolau@intel.com" <radu.nicolau@intel.com>,
 "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
 "narayanaprasad.athreya@caviumnetworks.com"
 <narayanaprasad.athreya@caviumnetworks.com>,
 "Shally.Verma@caviumnetworks.com" <Shally.Verma@caviumnetworks.com>,
 "Anoob.Joseph@caviumnetworks.com" <Anoob.Joseph@caviumnetworks.com>,
 "Vidya.Velumuri@caviumnetworks.com" <Vidya.Velumuri@caviumnetworks.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>
To: Akhil Goyal <akhil.goyal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 2C15D5F30
 for <dev@dpdk.org>; Thu, 18 Oct 2018 16:40:09 +0200 (CEST)
In-Reply-To: <cacde6d7-06c4-e77a-e887-e4485547ef24@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

16/10/2018 16:35, Akhil Goyal:
> > Akhil Goyal (3):
> >    security: support pdcp protocol
> >    crypto/dpaa2_sec: add sample pdcp descriptor apis
> >    crypto/dpaa2_sec: support pdcp offload
> >
> >   doc/guides/prog_guide/rte_security.rst      |  107 +-
> >   drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c |  257 ++
> >   drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h   |  208 +-
> >   drivers/crypto/dpaa2_sec/hw/desc.h          |    2 +-
> >   drivers/crypto/dpaa2_sec/hw/desc/pdcp.h     | 2796 +++++++++++++++++++
> >   lib/librte_security/rte_security.c          |    4 +
> >   lib/librte_security/rte_security.h          |   92 +
> >   7 files changed, 3450 insertions(+), 16 deletions(-)
> >   create mode 100644 drivers/crypto/dpaa2_sec/hw/desc/pdcp.h
> >
> Patchset applied to dpdk-next-crypto
> 
> minor modification as suggested by Anoob is done.

This patchset won't be part of the pull in master because of 2 issues:

- clang error:
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:2759:18: fatal error:
implicit conversion from enumeration type 'enum rte_security_pdcp_sn_size'
to different enumeration type 'enum pdcp_sn_size'

- doxygen error:
rte_security.h:225: warning: Found unknown command `\PDCP_SN_SIZE_5'
rte_security.h:226: warning: Found unknown command `\PDCP_SN_SIZE_7'
rte_security.h:227: warning: Found unknown command `\PDCP_SN_SIZE_12'
rte_security.h:228: warning: Found unknown command `\PDCP_SN_SIZE_15'
rte_security.h:229: warning: Found unknown command `\PDCP_SN_SIZE_18'

I think these doxygen comments can be removed.