From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] mbuf: clarify comment on adding TX offload
	flags
Date: Thu, 09 Jul 2015 15:59:35 +0200
Message-ID: <3236231.fXvrao6sCh@xps13>
References: <1436448159-8394-1-git-send-email-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 282E5C36E
 for <dev@dpdk.org>; Thu,  9 Jul 2015 16:00:42 +0200 (CEST)
Received: by wicmv11 with SMTP id mv11so2075478wic.1
 for <dev@dpdk.org>; Thu, 09 Jul 2015 07:00:42 -0700 (PDT)
In-Reply-To: <1436448159-8394-1-git-send-email-bruce.richardson@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-09 14:22, Bruce Richardson:
> The comment for TX offload flags stated that those flags started at bit
> 55 and then were added to the right of that, leaving 8 bits reserved for
> generic mbuf (i.e. non-offload) use. This comment may not have been
> clear as 5 of the 8 flags which were reserved have now been used for TX
> offloads.

We failed to properly review some patches which are now integrated in
version 1.8. So you cannot fix it without breaking API.
It's a bit sad but your patch fixing the comment is reasonnable.

Fixes: 711ba9e23e68 ("mbuf: remove aliasing of Tx offloading flags with Rx ones")
Fixes: 1c3b7c33e977 ("mbuf: add Tx offloading flags for tunnels")