dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Ananyev,
	Konstantin"
	<konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: rte_pktmbuf_alloc fails
Date: Thu, 22 May 2014 17:47:21 +0200	[thread overview]
Message-ID: <3243438.tFUQaShmoV@xps13> (raw)
In-Reply-To: <2441602.aZ8JVAEsGZ@xps13>

2014-04-17 17:00, Thomas Monjalon:
> Hi Konstantin,
> 
> 2014-04-07 08:53, Ananyev, Konstantin:
> > Yep indeed, there is a bug in eth_pcap_tx() that can cause mbuf
> > corruption.
> > I think it should be something like that instead:
> > 
> > --- a/lib/librte_pmd_pcap/rte_eth_pcap.c
> > +++ b/lib/librte_pmd_pcap/rte_eth_pcap.c
> > @@ -205,8 +205,9 @@ eth_pcap_tx(void *queue,
> > 
> >                 mbuf = bufs[i];
> >                 ret = pcap_sendpacket(tx_queue->pcap, (u_char*)
> > 
> > mbuf->pkt.data, mbuf->pkt.data_len);
> > -               if(likely(!ret))
> > -                       num_tx++;
> > +               if(unlikely(ret != 0))
> > +                       break;
> > +               num_tx++;
> > 
> >                 rte_pktmbuf_free(mbuf);
> >         
> >         }
> 
> Please could you send a patch with a commit log as described in
> http://dpdk.org/dev#send ?

I think you haven't sent patch for this bug.
Do you plan to do so?

Thanks
-- 
Thomas

  reply	other threads:[~2014-05-22 15:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-01 11:08 rte_pktmbuf_alloc fails Meir Tseitlin
     [not found] ` <CA+Typ9mJRUhSbOME=r3KFADxykKYN8snVAZ1JUEf8ohXbz-W7w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-01 11:53   ` Meir Tseitlin
     [not found]     ` <CA+Typ9kU8bPfT-9Be9O6uRAK-YWyJYAiMbtoCtbvXy4jQM-nJA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-07  7:26       ` Olivier MATZ
2014-04-07  8:53         ` Ananyev, Konstantin
     [not found]           ` <2601191342CEEE43887BDE71AB9772580EF94DE9-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-04-17 15:00             ` Thomas Monjalon
2014-05-22 15:47               ` Thomas Monjalon [this message]
2014-05-22 15:51                 ` Ananyev, Konstantin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3243438.tFUQaShmoV@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).