From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] virtio: fix link state regression
Date: Fri, 04 Dec 2015 16:27:15 +0100
Message-ID: <3243475.ZBIR4zOS0o@xps13>
References: <1449194904-9626-1-git-send-email-stephen@networkplumber.org>
 <20151204032953.GC29571@yliu-dev.sh.intel.com>
 <8CEF83825BEC744B83065625E567D7C219F8D635@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id D35068E85
 for <dev@dpdk.org>; Fri,  4 Dec 2015 16:28:25 +0100 (CET)
Received: by wmww144 with SMTP id w144so69351130wmw.0
 for <dev@dpdk.org>; Fri, 04 Dec 2015 07:28:25 -0800 (PST)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C219F8D635@IRSMSX108.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-12-04 15:25, Iremonger, Bernard:
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> > On Thu, Dec 03, 2015 at 06:08:24PM -0800, Stephen Hemminger wrote:
> > > Support for link state interrupt was broken on virtio by
> > >
> > > commit bda66c418c85 ("ethdev: add device fields from PCI layer")
> > >
> > > This is caused because the actual value of drv_flags is not set until
> > > after the resource_init has figured out whether it is using UIO or
> > > direct I/O instructions.
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > > ---
> > > There maybe other drivers with the same problem. It would have been
> > > better to move the structure elements (and break ABI) rather than
> > > assume it safe to copy them. Better to fail compiling.
> > 
> > I see no patch content.
> > 
> > 	--yliu
> 
> I have submitted a patch for this issue.
> 
> http://dpdk.org/dev/patchwork/patch/9345/
> 
> I have checked the other drivers, I found an issue with the bonding PMD.
> I have submitted a patch for this.
> 
> http://dpdk.org/dev/patchwork/patch/9342/
> 
> The remaining drivers look fine to me.

Thank you Bernard for the quick response.