From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] eventdev: fix unchecked return in default Rx adapter conf cb Date: Tue, 06 Feb 2018 21:24:53 +0100 Message-ID: <3243913.r7aDMFFJxM@xps> References: <1517352989-11720-1-git-send-email-vipin.varghese@intel.com> <1517768311-827-1-git-send-email-nikhil.rao@intel.com> <20180206190113.GA5868@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Jerin Jacob , vipin.varghese@intel.com, deepak.k.jain@intel.com To: Nikhil Rao Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id AC7A01B40B for ; Tue, 6 Feb 2018 21:24:57 +0100 (CET) In-Reply-To: <20180206190113.GA5868@jerin> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > The default adapter configuration callback is invoked when a Rx > > queue is added to the adapter and the adapter detects that a SW > > service is needed. The adapter needs to re-configure the device > > with an additional port and to do do, it needs to stop the > > device and restart it after it is done reconfiguring it. This > > patch adds code to check the return code of > > rte_event_dev_start() for both when the reconfiguration fails > > and when it succeeds and introduces a new error code (-EIO) > > for the first case. > > > > Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation") > > Coverity issue: 257000 > > > > Signed-off-by: Nikhil Rao > > Cc: stable@dpdk.org > Acked-by: Jerin Jacob Applied, thanks