From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ixgbe: Add missing rx_mbuf_alloc_failed statistics for vector PMD Date: Fri, 28 Nov 2014 16:24:06 +0100 Message-ID: <3243944.24MUMOEcxq@xps13> References: <1417166505-486-1-git-send-email-balazs.nemeth@intel.com> <20141128131831.GB10024@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Balazs Nemeth Return-path: In-Reply-To: <20141128131831.GB10024@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > > The statistics that is reported through the rx_nombuf fields in struct > > rte_eth_stats was not set when the vector PMD was used. The statistics > > should report the number of mbufs that could _not_ be allocated during > > rearm of the RX queue. The non-vector PMD reports it correctly. The > > use of either vector PMD or non-vector PMD depends on runtime > > configuration. Hence it is possible that a change in configuration > > would disable this statistics. To prevent this from happening, the > > statistics should be reported by both implementations. > > > > Signed-off-by: Balazs Nemeth > > Acked-by: Bruce Richardson Applied Thanks -- Thomas