From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C158C433E0 for ; Wed, 5 Aug 2020 09:12:18 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 00B1C22CA1 for ; Wed, 5 Aug 2020 09:12:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="uuUxhmUd"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Ef47KLLq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00B1C22CA1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 516F91BFF7; Wed, 5 Aug 2020 11:12:17 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 709772BB5 for ; Wed, 5 Aug 2020 11:12:16 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id E8167B2D; Wed, 5 Aug 2020 05:12:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 05 Aug 2020 05:12:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= OzT/RBfKB9httYBRFBPbojtVfw8hbJfPGtGCJ+0TJgk=; b=uuUxhmUdquDeC5sk 5SCOztT+fKdI2PVmTmlsAoJec0W1BTYOgj+Y2lP8brUJEK0jOqbUAFifn91/d3xP c892oABY2bgZk9VF3QSQmCjAMGc9Dw3/Vy7sXTVpC/2JMN09RNkRpTjNztxjY4Si tqS7lyNEnbLjf73x/atd50ZJrTgYqExMqyGAzQqkJZhtWSZbXOgzpWC9a20oG6Mg 63WInglQz2qqSzTkCSGPO4PrYpQsFOWvCGNlLF4A9FBd9iOx4LRf7jYT0kT0DhtT sCgAUpIcbexF7lsEDHnQurnjJXtuWm+TTJg1C3nHZaON0cyqoWZHnt+LABj2/BeW 81si1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=OzT/RBfKB9httYBRFBPbojtVfw8hbJfPGtGCJ+0TJ gk=; b=Ef47KLLqJyvgKpIqZabPatyz/5vUP76S3T4FIEYxj6CjHsh4oOLbjOKz9 a7HAEZA2UWW/5tf3fVDkl2i8tmnOvmfk8loyD8GZYZ+ntQsrPnNesiKwlWX9nAKj tiU3BSbhzGdtWjlQkJwENsWnmJm+ZGdlUXlZLF3KN12qIUfLJ1ypW+mrpPKHPtgf n9oIzds9KNvrlZAQyHBb1j0+Vh7s4r1l0IgVXWvaX14c1opuk9Qa70/Iqi6sF2QF xXiLTie8nou/F0n2ThPYc7CSF5bxNxh6xkDpscYSuCSFpDuUnz1uTfhghCn6kA3V 0ctZqBob/7EVUzTG+19SJaQmivo0w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeekgddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtufertd dttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepudeggfdvfeduffdtfeegle fghfeukefgfffhueejtdetuedtjeeuieeivdffgeehnecukfhppeejjedrudefgedrvddt fedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5FB6A3060067; Wed, 5 Aug 2020 05:12:13 -0400 (EDT) From: Thomas Monjalon To: Adrian Moreno Cc: dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com Date: Wed, 05 Aug 2020 11:12:12 +0200 Message-ID: <3247837.ecEkxrgKqk@thomas> In-Reply-To: <20200804073837.88189-1-amorenoz@redhat.com> References: <20200804073837.88189-1-amorenoz@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/08/2020 09:38, Adrian Moreno: > The PREFER_FALLTHROUGH check warns if a passthrough comment is found > because, in the kernel, the special macro "fallthrough" is prefered. > > Since that keyword is not defined in DPDK, ignore the warning. We could ask why not defining a similar keyword? > > Ignoring this check does not affect the MISSING_BREAK check that will > warn if a switch case/default is not preceded by break or a fallthrough > comment. > > Signed-off-by: Adrian Moreno > --- > devtools/checkpatches.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > index acf921ae0..4283ca82b 100755 > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ > PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ > SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\ > LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ > -NEW_TYPEDEFS,COMPARISON_TO_NULL" > +NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH" I would add this option between PREFER_KERNEL_TYPES and BIT_MACRO to maintain a bit of logic ordering.