From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable] [PATCH v5 1/2] mk: fix cross build
	errors
Date: Wed, 30 May 2018 10:32:24 +0200
Message-ID: <3248809.BvU3dfXijd@xps>
References: <VI1PR08MB316752A4CB8ADB1E2AF5CA958F6C0@VI1PR08MB3167.eurprd08.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Bruce Richardson <bruce.richardson@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: Gavin Hu <Gavin.Hu@arm.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7994811F5
 for <dev@dpdk.org>; Wed, 30 May 2018 10:32:27 +0200 (CEST)
In-Reply-To: <VI1PR08MB316752A4CB8ADB1E2AF5CA958F6C0@VI1PR08MB3167.eurprd08.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

30/05/2018 04:45, Gavin Hu:
> From: Bruce Richardson <bruce.richardson@intel.com>
> > On Tue, May 29, 2018 at 04:45:55PM +0200, Thomas Monjalon wrote:
> > > 28/05/2018 15:24, Bruce Richardson:
> > > > Would a simpler solution for this not be to put "-Wno-implicit-
> > fallthrough"
> > > > for pmdinfogen? GCC will not give a warning for an unrecognised "-Wno"
> > > > flag when compiling, unless there are other errors. This means we
> > > > can just use the flag without bothering with version checks.
> > >
> > > No, it does not work.
> > > I have this error with clang 5.0.1:
> > >     error: unknown warning option '-Wno-format-truncation'
> > >
> > Yes, you still need to check for GCC to use the flag, just not for a specific
> > version of GCC.
> >
> > /Bruce
> [Gavin Hu] Hi Thomas, '-Wno-format-truncation' is applied to gcc only, not to clang.
> Gcc, icc and clang have their own WERROR_FLAGS, they should not mix up with each other.

Now I understand what we missed from the beginning: I am testing with meson.
This flag is added unconditionnaly in config/meson.build.

> @Bruce,
> Yes, in this sense, I am really concerned about to add -Wno-implicit-fallthrough option in the pmdinfogen Makefile, as it impacts not only gcc, but also clang and icc.
> Maybe this not a best solution, as maybe it is not supported by all compilers. So should I fall back to the previous patch which check for the gcc version and apply the options for gcc only?