From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 0/2] fix compile with ICC and clang Date: Tue, 19 May 2015 12:32:50 +0200 Message-ID: <3255170.m2Jvvj9c1g@xps13> References: <1431961409-22252-1-git-send-email-helin.zhang@intel.com> <1431963656-22836-1-git-send-email-helin.zhang@intel.com> <20150518154325.GA8740@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Helin Zhang Return-path: Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 72B45C320 for ; Tue, 19 May 2015 12:33:35 +0200 (CEST) Received: by wgjc11 with SMTP id c11so12493599wgj.0 for ; Tue, 19 May 2015 03:33:35 -0700 (PDT) In-Reply-To: <20150518154325.GA8740@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-05-18 16:43, Bruce Richardson: > On Mon, May 18, 2015 at 11:40:54PM +0800, Helin Zhang wrote: > > Compile warnings on ICC and clang can be found, and treated as errors. > > Disabling those warnings forcedly can fix them. > > > > v2 changes: > > Added the fix for the compile error on clang. > > > > v3 changes: > > Reworded the commit titles. > > Series Acked-by: Bruce Richardson Applied, thanks I reworded the commit message and added reference to the breaking commit: http://dpdk.org/browse/dpdk/commit/?id=ff5c3960017cf Please consider giving this kind of explanation when fixing things, especially for special handling of base drivers.