dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] doc: announce cryptodev change to support EDDSA
@ 2024-07-22 14:53 Gowrishankar Muthukrishnan
  2024-07-24  5:07 ` Anoob Joseph
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Gowrishankar Muthukrishnan @ 2024-07-22 14:53 UTC (permalink / raw)
  To: dev, bruce.richardson, ciara.power, jerinj, fanzhang.oss,
	arkadiuszx.kusztal, kai.ji, jack.bond-preston, david.marchand,
	hemant.agrawal, pablo.de.lara.guarch, fiona.trahe, declan.doherty,
	matan, ruifeng.wang, abhinandan.gujjar, maxime.coquelin, chenbox,
	sunilprakashrao.uttarwar, andrew.boyer, ajit.khaparde,
	raveendra.padasalagi, vikas.gupta, g.singh, jianjay.zhou,
	lee.daly
  Cc: Anoob Joseph, zhangfei.gao, Gowrishankar Muthukrishnan

Announce the additions in cryptodev ABI to support EDDSA algorithm.

Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
--
RFC:
  https://patches.dpdk.org/project/dpdk/patch/0ae6a1afadac64050d80b0fd7712c4a6a8599e2c.1701273963.git.gmuthukrishn@marvell.com/
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 6948641ff6..fcbec965b1 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -147,3 +147,7 @@ Deprecation Notices
   will be deprecated and subsequently removed in DPDK 24.11 release.
   Before this, the new port library API (functions rte_swx_port_*)
   will gradually transition from experimental to stable status.
+
+* cryptodev: The enum ``rte_crypto_asym_xform_type`` and struct ``rte_crypto_asym_op``
+  will be extended to include new values to support EDDSA. This will break
+  ABI compatibility with existing applications that use these data types.
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* RE: [PATCH] doc: announce cryptodev change to support EDDSA
  2024-07-22 14:53 [PATCH] doc: announce cryptodev change to support EDDSA Gowrishankar Muthukrishnan
@ 2024-07-24  5:07 ` Anoob Joseph
  2024-07-24  6:46 ` [EXTERNAL] " Akhil Goyal
  2024-07-25 15:01 ` Kusztal, ArkadiuszX
  2 siblings, 0 replies; 6+ messages in thread
From: Anoob Joseph @ 2024-07-24  5:07 UTC (permalink / raw)
  To: Gowrishankar Muthukrishnan, dev@dpdk.org,
	bruce.richardson@intel.com, ciara.power@intel.com, Jerin Jacob,
	fanzhang.oss@gmail.com, arkadiuszx.kusztal@intel.com,
	kai.ji@intel.com, jack.bond-preston@foss.arm.com,
	david.marchand@redhat.com, hemant.agrawal@nxp.com,
	pablo.de.lara.guarch@intel.com, fiona.trahe@intel.com,
	declan.doherty@intel.com, matan@nvidia.com, ruifeng.wang@arm.com,
	abhinandan.gujjar@intel.com, maxime.coquelin@redhat.com,
	chenbox@nvidia.com, sunilprakashrao.uttarwar@amd.com,
	andrew.boyer@amd.com, ajit.khaparde@broadcom.com,
	raveendra.padasalagi@broadcom.com, vikas.gupta@broadcom.com,
	g.singh@nxp.com, jianjay.zhou@huawei.com, lee.daly@intel.com
  Cc: zhangfei.gao@linaro.org, Gowrishankar Muthukrishnan

> Subject: [PATCH] doc: announce cryptodev change to support EDDSA
> 
> Announce the additions in cryptodev ABI to support EDDSA algorithm.
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>

Acked-by: Anoob Joseph <anoobj@marvell.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [EXTERNAL] [PATCH] doc: announce cryptodev change to support EDDSA
  2024-07-22 14:53 [PATCH] doc: announce cryptodev change to support EDDSA Gowrishankar Muthukrishnan
  2024-07-24  5:07 ` Anoob Joseph
@ 2024-07-24  6:46 ` Akhil Goyal
  2024-07-25 15:01 ` Kusztal, ArkadiuszX
  2 siblings, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2024-07-24  6:46 UTC (permalink / raw)
  To: Gowrishankar Muthukrishnan, dev@dpdk.org,
	bruce.richardson@intel.com, ciara.power@intel.com, Jerin Jacob,
	fanzhang.oss@gmail.com, arkadiuszx.kusztal@intel.com,
	kai.ji@intel.com, jack.bond-preston@foss.arm.com,
	david.marchand@redhat.com, hemant.agrawal@nxp.com,
	pablo.de.lara.guarch@intel.com, fiona.trahe@intel.com,
	declan.doherty@intel.com, matan@nvidia.com, ruifeng.wang@arm.com,
	abhinandan.gujjar@intel.com, maxime.coquelin@redhat.com,
	chenbox@nvidia.com, sunilprakashrao.uttarwar@amd.com,
	andrew.boyer@amd.com, ajit.khaparde@broadcom.com,
	raveendra.padasalagi@broadcom.com, vikas.gupta@broadcom.com,
	g.singh@nxp.com, jianjay.zhou@huawei.com, lee.daly@intel.com
  Cc: Anoob Joseph, zhangfei.gao@linaro.org, Gowrishankar Muthukrishnan

> Announce the additions in cryptodev ABI to support EDDSA algorithm.
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> --
Acked-by: Akhil Goyal <gakhil@marvell.com>

> RFC:
>   https://patches.dpdk.org/project/dpdk/patch/0ae6a1afadac64050d80b0fd7712c4a6a8599e2c.1701273963.git.gmuthukrishn@marvell.com/
> ---
>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 6948641ff6..fcbec965b1 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -147,3 +147,7 @@ Deprecation Notices
>    will be deprecated and subsequently removed in DPDK 24.11 release.
>    Before this, the new port library API (functions rte_swx_port_*)
>    will gradually transition from experimental to stable status.
> +
> +* cryptodev: The enum ``rte_crypto_asym_xform_type`` and struct
> ``rte_crypto_asym_op``
> +  will be extended to include new values to support EDDSA. This will break
> +  ABI compatibility with existing applications that use these data types.
> --
> 2.21.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] doc: announce cryptodev change to support EDDSA
  2024-07-22 14:53 [PATCH] doc: announce cryptodev change to support EDDSA Gowrishankar Muthukrishnan
  2024-07-24  5:07 ` Anoob Joseph
  2024-07-24  6:46 ` [EXTERNAL] " Akhil Goyal
@ 2024-07-25 15:01 ` Kusztal, ArkadiuszX
  2024-07-31 12:57   ` Thomas Monjalon
  2 siblings, 1 reply; 6+ messages in thread
From: Kusztal, ArkadiuszX @ 2024-07-25 15:01 UTC (permalink / raw)
  To: Gowrishankar Muthukrishnan, dev@dpdk.org, Richardson, Bruce,
	ciara.power@intel.com, jerinj@marvell.com, fanzhang.oss@gmail.com,
	Ji,  Kai, jack.bond-preston@foss.arm.com, Marchand, David,
	hemant.agrawal@nxp.com, De Lara Guarch, Pablo, Trahe, Fiona,
	Doherty, Declan, matan@nvidia.com, ruifeng.wang@arm.com,
	Gujjar, Abhinandan S, maxime.coquelin@redhat.com,
	chenbox@nvidia.com, sunilprakashrao.uttarwar@amd.com,
	andrew.boyer@amd.com, ajit.khaparde@broadcom.com,
	raveendra.padasalagi@broadcom.com, vikas.gupta@broadcom.com,
	g.singh@nxp.com, jianjay.zhou@huawei.com, Daly, Lee
  Cc: Anoob Joseph, zhangfei.gao@linaro.org

> Announce the additions in cryptodev ABI to support EDDSA algorithm.
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>

Acked-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] doc: announce cryptodev change to support EDDSA
  2024-07-25 15:01 ` Kusztal, ArkadiuszX
@ 2024-07-31 12:57   ` Thomas Monjalon
  2024-08-07 17:21     ` [EXTERNAL] " Gowrishankar Muthukrishnan
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2024-07-31 12:57 UTC (permalink / raw)
  To: Gowrishankar Muthukrishnan, dev@dpdk.org, Richardson, Bruce,
	ciara.power@intel.com, jerinj@marvell.com, fanzhang.oss@gmail.com,
	Ji, Kai, jack.bond-preston@foss.arm.com, Marchand, David,
	hemant.agrawal@nxp.com, De Lara Guarch, Pablo, Trahe, Fiona,
	Doherty, Declan, matan@nvidia.com, ruifeng.wang@arm.com,
	Gujjar, Abhinandan S, maxime.coquelin@redhat.com,
	chenbox@nvidia.com, sunilprakashrao.uttarwar@amd.com,
	andrew.boyer@amd.com, ajit.khaparde@broadcom.com,
	raveendra.padasalagi@broadcom.com, vikas.gupta@broadcom.com,
	g.singh@nxp.com, jianjay.zhou@huawei.com, Daly, Lee
  Cc: Anoob Joseph, zhangfei.gao@linaro.org, Kusztal, ArkadiuszX

25/07/2024 17:01, Kusztal, ArkadiuszX:
> > Announce the additions in cryptodev ABI to support EDDSA algorithm.
> > 
> > Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> 
> Acked-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>

Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

Applied, thanks.

It means we are not able to add an algo without breaking ABI.
Is it something we can improve?



^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [EXTERNAL] Re: [PATCH] doc: announce cryptodev change to support EDDSA
  2024-07-31 12:57   ` Thomas Monjalon
@ 2024-08-07 17:21     ` Gowrishankar Muthukrishnan
  0 siblings, 0 replies; 6+ messages in thread
From: Gowrishankar Muthukrishnan @ 2024-08-07 17:21 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: Anoob Joseph, zhangfei.gao@linaro.org, Kusztal, ArkadiuszX,
	dev@dpdk.org, Richardson, Bruce, ciara.power@intel.com,
	Jerin Jacob, fanzhang.oss@gmail.com, Ji, Kai,
	jack.bond-preston@foss.arm.com, Marchand, David,
	hemant.agrawal@nxp.com, De Lara Guarch, Pablo, Trahe, Fiona,
	Doherty, Declan, matan@nvidia.com, ruifeng.wang@arm.com,
	Gujjar, Abhinandan S, maxime.coquelin@redhat.com,
	chenbox@nvidia.com, sunilprakashrao.uttarwar@amd.com,
	andrew.boyer@amd.com, ajit.khaparde@broadcom.com,
	raveendra.padasalagi@broadcom.com, vikas.gupta@broadcom.com,
	g.singh@nxp.com, jianjay.zhou@huawei.com, Daly, Lee

> It means we are not able to add an algo without breaking ABI.
> Is it something we can improve?
> 

Sure Thomas, we will address it in our patch, ensuring the long term solution as well.

Regards,
Gowrishankar

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-08-07 17:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-22 14:53 [PATCH] doc: announce cryptodev change to support EDDSA Gowrishankar Muthukrishnan
2024-07-24  5:07 ` Anoob Joseph
2024-07-24  6:46 ` [EXTERNAL] " Akhil Goyal
2024-07-25 15:01 ` Kusztal, ArkadiuszX
2024-07-31 12:57   ` Thomas Monjalon
2024-08-07 17:21     ` [EXTERNAL] " Gowrishankar Muthukrishnan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).