From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal: Fix device registration on FreeBSD Date: Mon, 27 Mar 2017 12:01:51 +0200 Message-ID: <3259292.ro3bpgFpyD@xps13> References: <20170321183215.8357-1-benjamin.walker@intel.com> <0ff897d0-0541-652b-c77b-6369c3e41a67@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Shreyansh Jain To: Ben Walker Return-path: Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id CFF16FA7A for ; Mon, 27 Mar 2017 12:01:55 +0200 (CEST) Received: by mail-wr0-f170.google.com with SMTP id w11so35746459wrc.3 for ; Mon, 27 Mar 2017 03:01:55 -0700 (PDT) In-Reply-To: <0ff897d0-0541-652b-c77b-6369c3e41a67@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-03-27 11:34, Shreyansh Jain: > On Wednesday 22 March 2017 12:02 AM, Ben Walker wrote: > > The FreeBSD implementation wasn't registering new devices > > with the device framework on start up. However, common > > code attempts to unregister them on shutdown which causes > > a SEGFAULT. This fix makes the FreeBSD code do the same > > thing as the Linux code for registration. > > > > Signed-off-by: Ben Walker > > --- > > lib/librte_eal/bsdapp/eal/eal_pci.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > I can't vouch for BSD as I don't have that environment to verify. But, > the patch looks fine to me as compared to Linux changes. > > so, if my Ack makes sense: > > Acked-by: Shreyansh Jain Applied, thanks