From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5 09/17] crypto: get rid of crypto driver register callback Date: Wed, 22 Jun 2016 15:44:23 +0200 Message-ID: <3259828.fSm0GhbzkY@xps13> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1466586396-22618-10-git-send-email-shreyansh.jain@nxp.com> <20160622132752.GA6785@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Shreyansh Jain , dev@dpdk.org, viktorin@rehivetech.com To: Neil Horman Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 8D694C33A for ; Wed, 22 Jun 2016 15:44:25 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id f126so88483073wma.1 for ; Wed, 22 Jun 2016 06:44:25 -0700 (PDT) In-Reply-To: <20160622132752.GA6785@hmsreliant.think-freely.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-06-22 09:27, Neil Horman: > > +++ b/lib/librte_cryptodev/rte_cryptodev_version.map > > - rte_cryptodev_pmd_driver_register; > NAK, you can't just remove exported symbols without going through the > deprecation process. Better still would be to only expose it for DPDK_16.04 and > hide it in the next release This function is not called by the application. Thus there is no ABI break.