From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: ethdev flags and capabilities Date: Tue, 01 May 2018 22:41:09 +0200 Message-ID: <3264503.09g30QS5gu@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: declan.doherty@intel.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, bruce.richardson@intel.com, olivier.matz@6wind.com To: dev@dpdk.org Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 5259A23B for ; Tue, 1 May 2018 22:41:12 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since DPDK 18.05-rc1, we have 2 new fields in rte_eth_dev_info: const uint32_t *dev_flags; uint64_t dev_capa; The field dev_flags (http://dpdk.org/commit/736b30ebf2) is a pointer to rte_eth_dev_data.dev_flags for these bits: RTE_ETH_DEV_INTR_LSC RTE_ETH_DEV_BONDED_SLAVE RTE_ETH_DEV_INTR_RMV RTE_ETH_DEV_REPRESENTOR The field dev_capa (http://dpdk.org/commit/cac923cfea) is an integer for these bits: RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP How can we merge them? Should we move the capabilities in rte_eth_dev_data.dev_flags? Or do we want to keep the capabilities in rte_eth_dev_info? Is it OK to use pointers in rte_eth_dev_info or should we make a copy of rte_eth_dev_data fields? We need to take a decision before RC3. Thanks