From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] fm10k: improvement for vPMD compiling Date: Tue, 24 Nov 2015 11:48:39 +0100 Message-ID: <3264629.GMzNar2180@xps13> References: <1448345753-10380-1-git-send-email-jing.d.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Chen Jing D(Mark)" Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id ECD6B8E64 for ; Tue, 24 Nov 2015 11:49:56 +0100 (CET) Received: by wmww144 with SMTP id w144so132773555wmw.1 for ; Tue, 24 Nov 2015 02:49:56 -0800 (PST) In-Reply-To: <1448345753-10380-1-git-send-email-jing.d.chen@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-11-24 14:15, Chen Jing D: > fm10k driver will meet compile error on non-x86 platforms due to > SSE instructions. Original implementation didn't have switch to > turn off vPMD. > The improvement introduces a macro to turn on/off vPMD functions, > it's on by default. On non-x86 platforms, it can simply be turned > off to fix compile issue. > > Signed-off-by: Chen Jing D(Mark) The non-x86 platforms may have a specific implementation. That's why we should name fm10k_rxtx_vec.c with _sse suffix instead of _vec. Applied, thanks