From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Michael Qiu <michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] librte_pmd_ixgbe: Add queue start failure check
Date: Tue, 27 Jan 2015 11:00:46 +0100 [thread overview]
Message-ID: <3276396.omH03JUPtz@xps13> (raw)
In-Reply-To: <1421333111-22136-1-git-send-email-michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Hi Michael,
I'm clearly not the maintainer of ixgbe, so I'd prefer someone else
reviewing this patch. However I have few comments.
2015-01-15 22:45, Michael Qiu:
> - ixgbe_dev_rxtx_start(dev);
> + err = ixgbe_dev_rxtx_start(dev);
> + if (err < 0) {
> + PMD_INIT_LOG(ERR, "Unable to start rxtx queues\n");
\n is not needed in PMD_INIT_LOG.
Is this useful to print a log here, given that there already has
some logs in ixgbe_dev_rxtx_start?
> + PMD_INIT_LOG(ERR, "Start tx queue failed\n");
[...]
> + PMD_INIT_LOG(ERR, "Start rx queue failed\n");
Please remove \n.
Except these minor comments, it looks good.
Thanks
--
Thomas
next prev parent reply other threads:[~2015-01-27 10:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 14:45 [PATCH] librte_pmd_ixgbe: Add queue start failure check Michael Qiu
2015-01-19 15:50 ` Qiu, Michael
[not found] ` <1421333111-22136-1-git-send-email-michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-27 10:00 ` Thomas Monjalon [this message]
2015-01-27 12:00 ` Qiu, Michael
[not found] ` <533710CFB86FA344BFBF2D6802E60286CBAD55-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-27 14:14 ` Thomas Monjalon
2015-01-27 12:16 ` [PATCH v2] " Michael Qiu
[not found] ` <1422360978-16954-1-git-send-email-michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-27 14:12 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3276396.omH03JUPtz@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).