From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] librte_pmd_ixgbe: Add queue start failure
	check
Date: Tue, 27 Jan 2015 11:00:46 +0100
Message-ID: <3276396.omH03JUPtz@xps13>
References: <1421333111-22136-1-git-send-email-michael.qiu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Michael Qiu <michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1421333111-22136-1-git-send-email-michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Michael,

I'm clearly not the maintainer of ixgbe, so I'd prefer someone else
reviewing this patch. However I have few comments.

2015-01-15 22:45, Michael Qiu:
> -	ixgbe_dev_rxtx_start(dev);
> +	err = ixgbe_dev_rxtx_start(dev);
> +	if (err < 0) {
> +		PMD_INIT_LOG(ERR, "Unable to start rxtx queues\n");

\n is not needed in PMD_INIT_LOG.

Is this useful to print a log here, given that there already has
some logs in ixgbe_dev_rxtx_start?

> +				PMD_INIT_LOG(ERR, "Start tx queue failed\n");
[...]
> +				PMD_INIT_LOG(ERR, "Start rx queue failed\n");

Please remove \n.

Except these minor comments, it looks good.
Thanks
-- 
Thomas