From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] hash: optimize the softrss computation
Date: Sat, 07 Oct 2017 00:31:24 +0200
Message-ID: <32775928.OAvXbfsJxg@xps>
References: <1503403355-4917-1-git-send-email-zhouyates@gmail.com>
 <CANDrEHk6oz5ebCOE2BrCoUWKgQLVLP3_298JBSLe2=7zCetP2w@mail.gmail.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CC23277@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
 Vladimir Medvedkin <medvedkinv@gmail.com>
To: Yangchao Zhou <zhouyates@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CA12E1B1BC
 for <dev@dpdk.org>; Sat,  7 Oct 2017 00:31:25 +0200 (CEST)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC23277@IRSMSX108.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

22/09/2017 17:33, De Lara Guarch, Pablo:
> From: Vladimir Medvedkin
> > 2017-08-22 15:02 GMT+03:00 Yangchao Zhou <zhouyates@gmail.com>:
> > 
> > > Use rte_bsf32 and fast bit unset operation to optimize the softrss
> > > computation.
> > > The following measurements shows improvement over the default softrss
> > > computation function.
> > >
> > > tuple lens old(cycles) new(cycles)
> > >     3        1225         337
> > >     9        3743         992
> > >
> > > Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> 
> Commit message is a bit long. Could you wrap it to have less than 75 characters per line?
> Although, the patch itself has lines with more than 90 characters, which should be avoided:
> 
> http://dpdk.org/ml/archives/test-report/2017-August/027283.html
> 
> Last thing, the "Reviewed-by" has an extra space, before the name.

Applied, thanks