From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] doc: add author on cc to git fixline alias Date: Thu, 03 Aug 2017 15:29:36 +0200 Message-ID: <3294755.LIHlXguKSE@xps> References: <1499866732-17085-1-git-send-email-harry.van.haaren@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Mcnamara, John" To: "Van Haaren, Harry" Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8C48C2BC9 for ; Thu, 3 Aug 2017 15:29:39 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > With this commit, the correct method to use git fixline to indicate a fix > > of a previous commit has changed. The new rules require the author of the > > original code that is being fixed to be on CC. > > > > The logic behind this improvement is that if there is a genuine bug, one > > of the ideal people to review is the author of the original code being > > fixed. Adding them on Cc makes them aware of the patch, avoiding it from > > being passed by accidentally while reading the mailing-list. > > > > Given that the original author (now on Cc:) might not actually review, > > there is no value in keeping the Cc: in git commit history. If the > > original author performs a review, their Reviewed-by: or Acked-by: is > > stored in git history (same as now). > > > > Signed-off-by: Harry van Haaren > > Acked-by: John McNamara Acked-by: Thomas Monjalon Applied, thanks Please update also the alias on the website.