From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v8 3/4] examples: add l3fwd-thread example in performance-thread Date: Mon, 07 Dec 2015 12:20:46 +0100 Message-ID: <3297170.pf9yERCVcv@xps13> References: <1449159683-7092-3-git-send-email-ian.betts@intel.com> <21971802.WvAiNsWy31@xps13> <877C1F8553E92F43898365570816082F35C0C0CE@IRSMSX103.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Betts, Ian" Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 6539B95A1 for ; Mon, 7 Dec 2015 12:21:59 +0100 (CET) Received: by wmuu63 with SMTP id u63so136045421wmu.0 for ; Mon, 07 Dec 2015 03:21:59 -0800 (PST) In-Reply-To: <877C1F8553E92F43898365570816082F35C0C0CE@IRSMSX103.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-12-07 04:46, Betts, Ian: > >>I had no time to check how it works. > >> I'm just surprised that you introduce a new config option. > >> +DIRS-$(CONFIG_RTE_PERFORMANCE_THREAD) += performance-thread > > I think this option should be removed. > > It is only to ensure that performance-thread example is built, along with all other examples, > if you run "make" top level of examples folder. > Also to ensure it is only enabled for x86_64 linux. > > Is there is another way ? The config options must be avoided for libraries and not used for examples. You can use CONFIG_RTE_ARCH_X86_64.