From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [git pull] virtio changes for 17.11-rc1 Date: Mon, 9 Oct 2017 09:13:46 +0200 Message-ID: <32c86cdd-91ad-b84d-2495-165a2c949751@redhat.com> References: <20171006064558.GE1545@yliu-home> <1963011.gX7c8kfyiN@xps> <20171009025502.GJ1545@yliu-home> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: olivier.matz@6wind.com, dev@dpdk.org To: Yuanhan Liu , Thomas Monjalon Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 2F4CE1B027 for ; Mon, 9 Oct 2017 09:13:52 +0200 (CEST) In-Reply-To: <20171009025502.GJ1545@yliu-home> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/09/2017 04:55 AM, Yuanhan Liu wrote: > On Sat, Oct 07, 2017 at 04:37:53PM +0200, Thomas Monjalon wrote: >> 06/10/2017 08:45, Yuanhan Liu: >>> Hi Thomas, >>> >>> Please consider pulling following virtio changes for 17.11-rc1 at >>> git://dpdk.org/next/dpdk-next-virtio master >> >> There is a compilation error on ARM with >> "net/virtio: rationalize setting of Rx/Tx handlers" >> An include of rte_cpuflags.h is missing. >> >> There is also an error seen by clang in >> "vhost-user: add support to IOTLB miss slave requests" >> implicit conversion from enumeration type 'enum VhostUserSlaveRequest' >> to different enumeration type 'VhostUserRequest' >> >> This last error may be a real issue because VHOST_USER_SLAVE_IOTLB_MSG in >> VhostUserSlaveRequest can be understood as VHOST_USER_GET_FEATURES in >> VhostUserRequest. > > It won't be an issue, as the vhost-user frontend can distinguish it: > the two different kind of messages are sent over by two different fd. I agree this is not an issue. Thanks, Maxime