From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 00/10] Coverity fixes for EAL memory Date: Tue, 17 Apr 2018 20:59:14 +0200 Message-ID: <33130999.IW4UYd3WLM@xps> References: <2822934.JnSj6TxSKo@xps> <1f840947-c8ab-3fe1-4b00-3fd4a14e135b@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Burakov, Anatoly" Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A589ACFC6 for ; Tue, 17 Apr 2018 20:59:17 +0200 (CEST) In-Reply-To: <1f840947-c8ab-3fe1-4b00-3fd4a14e135b@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/04/2018 18:09, Burakov, Anatoly: > On 17-Apr-18 4:56 PM, Thomas Monjalon wrote: > > 17/04/2018 17:50, Anatoly Burakov: > >> This patchset fixes a host of coverity issues in memory subsystem > >> introduced with recent DPDK memory hotplug patchset. > >> > >> Coverity issues fixed: > >> - 272601 - leaking fd > >> - 272560 - double close fd > >> - 272568 - leaking fd > >> - 272570 - leaking fd > >> - 272589 - dereference before null check > >> - 272602 - freeing wrong pointer > >> - 272608 - expression does nothing > >> - 272577 - negative return not handled > >> - 272578 - negative return not handled > >> - 272584 - use after free > > > > Looks like you should buy a Coverity license > > to run it locally before submitting ;) > > Well, in fairness, most of these issues (and similar issues submitted in > another patchset) will not ever manifest themselves under normal > circumstances, so it's not as bad as it perhaps might present itself. Just kidding :) Thanks for the reactivity.