From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [PATCH v2 01/11] librte_cryptodev: Add rte_device
 pointer in cryptodevice
Date: Thu, 12 Jan 2017 17:56:45 +0530
Message-ID: <3315de84-8f28-c5d0-dc3c-5faa86a2ea7a@nxp.com>
References: <20161205125540.6419-1-akhil.goyal@nxp.com>
 <20161222201700.20020-1-akhil.goyal@nxp.com>
 <20161222201700.20020-2-akhil.goyal@nxp.com>
 <E115CCD9D858EF4F90C690B0DCB4D897476C075F@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>, "Doherty, Declan"
 <declan.doherty@intel.com>, "hemant.agrawal@nxp.com"
 <hemant.agrawal@nxp.com>, "Mcnamara, John" <john.mcnamara@intel.com>,
 "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02on0048.outbound.protection.outlook.com [104.47.38.48])
 by dpdk.org (Postfix) with ESMTP id 32AC0689B
 for <dev@dpdk.org>; Thu, 12 Jan 2017 13:26:58 +0100 (CET)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D897476C075F@IRSMSX108.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/9/2017 7:04 PM, De Lara Guarch, Pablo wrote:
> Hi,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal
>> Sent: Thursday, December 22, 2016 8:17 PM
>> To: dev@dpdk.org
>> Cc: thomas.monjalon@6wind.com; Doherty, Declan; De Lara Guarch, Pablo;
>> hemant.agrawal@nxp.com; Mcnamara, John; nhorman@tuxdriver.com;
>> Akhil Goyal
>> Subject: [dpdk-dev] [PATCH v2 01/11] librte_cryptodev: Add rte_device
>> pointer in cryptodevice
>>
>> This patch will not be required as some parallel work is going
>> on to add it across all crypto devices.
>>
> Could you tell me the patch that is going to add this?
> In that case, you can drop this and just say that your patchset depends on it.
>
> Also, the title should be "cryptodev: add rte_device pointer in crypto device".
> Note that for libraries, you just need the name of the library (i.e. cryptodev).
> The other thing is that the first letter should be lowercase. Could you change this in the other patches too?
>
>
> Thanks,
> Pablo
>
Thanks for your comments Pablo.

There is some discussion ongoing regarding bus model for DPAA2 platform. 
This change is already there for ethdev and we would be replicating the 
same for cryptodev, once the bus model patches are completed. This is 
added here so that compilation is not broken for subsequent patches.

For title, I will correct that in next version.

Thanks,
Akhil