From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 1/2] net/softnic: enable flow classification
	function
Date: Thu, 07 Dec 2017 23:16:48 +0100
Message-ID: <3321524.KpWgZ7mKTU@xps>
References: <20171130200843.98621-1-jasvinder.singh@intel.com>
 <20171130200843.98621-2-jasvinder.singh@intel.com>
 <f42ee212-c7f1-a5b9-c70c-e555da346a38@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, cristian.dumitrescu@intel.com
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Jasvinder Singh <jasvinder.singh@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 35F367CBD
 for <dev@dpdk.org>; Thu,  7 Dec 2017 23:16:53 +0100 (CET)
In-Reply-To: <f42ee212-c7f1-a5b9-c70c-e555da346a38@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

07/12/2017 22:02, Ferruh Yigit:
> On 11/30/2017 12:08 PM, Jasvinder Singh wrote:
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_FLOW_CLASSIFY)  += -lrte_flow_classify
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_PIPELINE)       += -lrte_pipeline
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE)            += --whole-archive
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE)          += -lrte_table
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE)            += --no-whole-archive
> 
> I think it is better to move rte_table between whole-archive flags, but I
> vaguely remember Thomas preferred this in the past, so adding him for comment.

Yes it is good to keep the order, and insert whole-archive flags
where necessary.

Ideally we should not require these flags.
Just checking: you need them for static link of libs
while dynamically linking the PMDs, right?