From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 01/17] ixgbe: use the right debug macro
Date: Tue, 02 Sep 2014 16:21:18 +0200
Message-ID: <3333103.135tnuTvaT@xps13>
References: <1409567080-27083-1-git-send-email-david.marchand@6wind.com>
 <CADNuJVpLLfiC_ROBkYQguHUGTgXNC1Bdu7HwveXcA23_Q3twxA@mail.gmail.com>
 <CALwxeUuC2O-YqB8yG01ZiBE2C7qQeCR2Km2gQ0i1fk+CHqXJ2w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Jay Rolette <rolette-bIuJOMs36aleGPcbtGPokg@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <CALwxeUuC2O-YqB8yG01ZiBE2C7qQeCR2Km2gQ0i1fk+CHqXJ2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-09-02 16:16, David Marchand:
> >>  /* Macros to check for invlaid function pointers. */

Invlaid is an invalid word ;)

> >> -#define        FUNC_PTR_OR_ERR_RET(func, retval) do {             \
> >> -       if ((func) == NULL) {                              \
> >> -               DEBUGOUT("%s:%d function not supported\n", \
> >> -                       __func__, __LINE__);               \
> >> -               return (retval);                           \
> >> -       }                                                  \
> >> +#define        FUNC_PTR_OR_ERR_RET(func, retval) do {              \
> >> +       if ((func) == NULL) {                               \
> >> +               PMD_DRV_LOG("%s:%d function not supported", \
> >> +                           __func__, __LINE__);            \
> >> +               return retval;                            \
> >>
> > Need to keep the parens around retval in your macro
> 
> Actually, checkpatch complained about this.
> So I can keep the parenthesis, but then I don't want Thomas to tell me my
> patch does not pass checkpatch :-)

You're right, I care about checkpatch :)
I don't see a case where parens are needed with return. Please give an example.

-- 
Thomas