From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] testpmd: fix typo when closing port
Date: Wed, 08 Jun 2016 19:59:10 +0200
Message-ID: <33331795.Sa6neYO5Xo@xps13>
References: <1465399231-7023-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <43127148.6njRUyVk9W@xps13>
 <B27915DBBA3421428155699D51E4CFE20257DD57@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id 7CA99C134
 for <dev@dpdk.org>; Wed,  8 Jun 2016 19:59:12 +0200 (CEST)
Received: by mail-wm0-f50.google.com with SMTP id n184so192747130wmn.1
 for <dev@dpdk.org>; Wed, 08 Jun 2016 10:59:12 -0700 (PDT)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE20257DD57@IRSMSX103.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-06-08 17:18, Mcnamara, John:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > 2016-06-08 16:20, Pablo de Lara:
> > >  		if (rte_atomic16_cmpset(&(port->port_status),
> > >  			RTE_PORT_HANDLING, RTE_PORT_CLOSED) == 0)
> > > -			printf("Port %d can not be set into stopped\n", pi);
> > > +			printf("Port %d can not be set into closed\n", pi);
> > 
> > My english would say "Port cannot be closed".
> > Am I wrong?
> 
> Yes, that is better or "Port cannot be set to closed" if "closed" is a
> state like here.

Applied with John's proposal.