From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 0/8] ACL: various fixes and cleanups
Date: Thu, 04 Jun 2015 11:27:29 +0200
Message-ID: <33335664.AQckXK60Ox@xps13>
References: <1433373024-5558-1-git-send-email-konstantin.ananyev@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 1AFA75A9A
 for <dev@dpdk.org>; Thu,  4 Jun 2015 11:28:22 +0200 (CEST)
Received: by wibdq8 with SMTP id dq8so118319520wib.1
 for <dev@dpdk.org>; Thu, 04 Jun 2015 02:28:22 -0700 (PDT)
In-Reply-To: <1433373024-5558-1-git-send-email-konstantin.ananyev@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Konstantin,

2015-06-04 00:10, Konstantin Ananyev:
> This patch-set is based on:
> [PATCHv2 0/3] ACL: Fix bug in acl_merge_trie() and add a new test-case for it to the UT.
> 
> Konstantin Ananyev (8):
>  ACL: fix invalid rule wildness calculation for RTE_ACL_FIELD_TYPE_BITMASK
>  ACL: code cleanup - use global RTE_LEN2MASK macro
>  ACL: add function to check rte_acl_build() input parameters
>  ACL: fix rebuilding a trie for subset of rules
>  ACL: introduce RTE_ACL_MASKLEN_TO_BITMASK macro
>  ACL: cleanup remove unused code from acl_bld.c
>  ACL: fix remove ambiguity between rules at UT
>  ACL: add new test-cases into UT

Commit titles would be more useful if they shortly explain the goal instead
of giving some function/macro names. It should be thought as a changelog entry
and reflect behavioral change.
On a side note, the keyword ACL: should be lowercase.

In the case of fixes, adding a Fixes: line may help.
It can be generated with this command:
	git log -1 --abbrev=12 --format='Fixes: %h ("%s")' <commit>

Thanks