From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] app/testpmd: set keep CRC offload flag
Date: Mon, 16 Jul 2018 00:33:12 +0200
Message-ID: <3345086.t8rsocCVh4@xps>
References: <20180703184452.43832-1-ferruh.yigit@intel.com>
 <8CEF83825BEC744B83065625E567D7C260CC6B7B@IRSMSX107.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Iremonger, Bernard" <bernard.iremonger@intel.com>, "Lu,
 Wenzhuo" <wenzhuo.lu@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 7CB022BF4
 for <dev@dpdk.org>; Mon, 16 Jul 2018 00:33:18 +0200 (CEST)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CC6B7B@IRSMSX107.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/07/2018 15:43, Iremonger, Bernard:
> From: Yigit, Ferruh
> > If "--disable-crc-strip" testpmd parameter issued, it removes the
> > DEV_RX_OFFLOAD_CRC_STRIP flag.
> > With introduction of new DEV_RX_OFFLOAD_KEEP_CRC offload flag, this flag
> > also should be set when this parameter issued.
> > 
> > Fixes: 3d12dceed2df ("ethdev: add new offload flag to keep CRC")
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>

Applied, thanks