From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v7 0/6] Fail-safe\ethdev: fix removal handling lack Date: Sun, 21 Jan 2018 20:28:09 +0000 Message-ID: <334636fe-62e9-e51d-055a-b8369478eff7@intel.com> References: <1516274834-19755-1-git-send-email-matan@mellanox.com> <1516482744-8415-1-git-send-email-matan@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Thomas Monjalon , dev@dpdk.org To: Matan Azrad , Adrien Mazarguil , Gaetan Rivet Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id C0373A84C for ; Sun, 21 Jan 2018 21:28:12 +0100 (CET) In-Reply-To: <1516482744-8415-1-git-send-email-matan@mellanox.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/20/2018 9:12 PM, Matan Azrad wrote: > There is time between the physical removal of the device until sub-device PMDs get a RMV interrupt. > At this time DPDK PMDs and applications still don't know about the removal and may call sub-device control operation which should return an error. > > This series adds new ethdev operation to check device removal, adds support for it in mlx PMDs, adjust ethdev APIs to return -EIO in case of removal and fixes the fail-safe bug of removal error report. > > V2: > Remove ENODEV definition. > Remove checks from all mlx control commands. > Add new devop - "is_removed". > Implement it in mlx4 and mlx5. > Fix failsafe bug by the new devop. > > V3: > Adjust ethdev APIs removal error report. > Change failsafe check to check eth_dev* return values. > Remove backporting of fail-safe patch. > > V4: > Improve fail-safe internal API to adjust the actual error value as discussed. > Remove "Fixes" lines from fail-safe patch. > No changes in ethdev\mlx patches. > > V5: > Rebase on top of master-net-mlx. > > V6: > Move ethdev new API to be EXPERIMENTAL. > > V7: > Fix API return value description. > Swap checks in the new API as Konstantin suggested. > Add comment in the API as Ferruh suggested. > > Matan Azrad (6): > ethdev: add devop to check removal status > net/mlx4: support a device removal check operation > net/mlx5: support a device removal check operation > ethdev: adjust APIs removal error report > ethdev: adjust flow APIs removal error report > net/failsafe: fix removed device handling Series applied to dpdk-next-net/master, thanks.