From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] hash: fix scaling by reducing contention Date: Wed, 04 Nov 2015 01:03:24 +0100 Message-ID: <3350203.vEc0KsLCbN@xps13> References: <1446207772-58543-1-git-send-email-pablo.de.lara.guarch@intel.com> <1446215848-122581-1-git-send-email-pablo.de.lara.guarch@intel.com> <59AF69C657FD0841A61C55336867B5B03596598C@IRSMSX103.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "De Lara Guarch, Pablo" Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id DE7588E6C for ; Wed, 4 Nov 2015 01:05:02 +0100 (CET) Received: by wmeg8 with SMTP id g8so97818930wme.0 for ; Tue, 03 Nov 2015 16:05:02 -0800 (PST) In-Reply-To: <59AF69C657FD0841A61C55336867B5B03596598C@IRSMSX103.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > If using multiple cores on a system with hardware transactional memory > > support, thread scaling does not work, as there was a single point in the > > hash library which is a bottleneck for all threads, which is the > > "free_slots" ring, which stores all the indices of the free slots in the > > table. > > > > This patch fixes the problem, by creating a local cache per logical core, > > which stores locally indices of free slots, so most times, writer threads > > will not interfere each other. > > > > Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation") > > > > Signed-off-by: Pablo de Lara > > Acked-by: Bruce Richardson Applied, thanks