From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 3/3] mk: do not generate LDLIBS from
	directory dependencies
Date: Tue, 24 Oct 2017 02:11:33 +0200
Message-ID: <33542091.69SN6enjHd@xps>
References: <20171005125017.GA12160@bricha3-MOBL3.ger.corp.intel.com>
 <20171012160421.8337-1-olivier.matz@6wind.com>
 <20171012160421.8337-4-olivier.matz@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, gage.eads@intel.com, santosh.shukla@caviumnetworks.com,
 bruce.richardson@intel.com, jerin.jacob@caviumnetworks.com
To: Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 5C35E1B6FF
 for <dev@dpdk.org>; Tue, 24 Oct 2017 02:11:35 +0200 (CEST)
In-Reply-To: <20171012160421.8337-4-olivier.matz@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

12/10/2017 18:04, Olivier Matz:
> The list of libraries in LDLIBS was generated from the DEPDIRS-xyz
> variable. This is valid when the subdirectory name match the library
> name, but it's not always the case, especially for PMDs.
> 
> The patches removes this feature and explicitly adds the proper
> libraries in LDLIBS.

Some DEPDIRS are defined in conditionals.
The same conditionals must be used for LDLIBS.
See 2 fixes below:

> --- a/lib/librte_port/Makefile
> +++ b/lib/librte_port/Makefile
> @@ -38,6 +38,8 @@ LIB = librte_port.a
>  ifeq ($(CONFIG_RTE_PORT_PCAP),y)
>  LDLIBS += -lpcap
>  endif
> +LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev
> +LDLIBS += -lrte_ip_frag -lrte_sched -lrte_kni

+LDLIBS += -lrte_ip_frag -lrte_sched
+ifeq ($(CONFIG_RTE_LIBRTE_KNI),y)
+LDLIBS += -lrte_kni
+endif

> --- a/lib/librte_table/Makefile
> +++ b/lib/librte_table/Makefile
> @@ -38,6 +38,8 @@ LIB = librte_table.a
>  
>  CFLAGS += -O3
>  CFLAGS += $(WERROR_FLAGS)
> +LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_port
> +LDLIBS += -lrte_lpm -lrte_hash -lrte_acl

+LDLIBS += -lrte_lpm -lrte_hash
+ifeq ($(CONFIG_RTE_LIBRTE_ACL),y)
+LDLIBS += -lrte_acl
+endif