From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergio Gonzalez Monroy Subject: Re: [PATCH] eal: use get_mempolicy(2) to find numa socket on Linux Date: Mon, 3 Jul 2017 15:11:11 +0100 Message-ID: <33607ba3-f359-de3e-1351-66140e693a44@intel.com> References: <25388622.XuEPg0MkIL@polaris> <8bbfaa04-fa99-8c2a-c0ec-a91059809b73@intel.com> <4398639.Xci2ANazcN@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Ilya Maximets , "Richardson, Bruce" , Jerin Jacob , "hemant.agrawal@nxp.com" To: Thomas Monjalon , Gregory Etelson Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1F9B82BB4 for ; Mon, 3 Jul 2017 16:11:33 +0200 (CEST) In-Reply-To: <4398639.Xci2ANazcN@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01/07/2017 15:18, Thomas Monjalon wrote: > 21/06/2017 17:49, Sergio Gonzalez Monroy: >> I think following the discussion of libnuma dependency in another thread >> [1], you would need to implement a similar approach and keep the old >> method while providing this alternative if libnuma is present. > Considering that libnuma becomes mandatory to build DPDK on NUMA-capable > systems, we can assume there is only one CPU socket if libnuma is > unavailable. > >> As Ilya mentions in the thread, this is usually the job of tools such as >> autotools, cmake or meson but given that we do not have such tools in >> DPDK yet, we rely in a build time config option for libnuma. >> >> Given that we already have a libnuma config option for VHOST, we might >> be adding anew one for hugepage balancing, I think it would make sense >> to just have single CONFIG_RTE_LIBNUMA option instead. >> >> Thoughts? > I am not sure about merging every NUMA options into one. > It may be interesting to track different NUMA features requiring libnuma. Do you see the case where a system with libnuma we want to use the support for hugapage allocation but not for vhost? In my opinion this looks like a manual check for libnuma where with a different build system would have been automated. Cheers, Sergio > Anyway, this patch needs to be rebased now that Ilya's patch is applied.