From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: fix external shared library dependencies of libraries Date: Tue, 08 Dec 2015 11:11:04 +0100 Message-ID: <33721268.SXJjAvgPEg@xps13> References: <87f15b40e6a0cad89a9eb94dd173cd20878b591a.1449563079.git.pmatilai@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Panu Matilainen Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 21C06376C for ; Tue, 8 Dec 2015 11:12:19 +0100 (CET) Received: by wmvv187 with SMTP id v187so206312394wmv.1 for ; Tue, 08 Dec 2015 02:12:19 -0800 (PST) In-Reply-To: <87f15b40e6a0cad89a9eb94dd173cd20878b591a.1449563079.git.pmatilai@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Panu, 2015-12-08 10:30, Panu Matilainen: > --- a/lib/librte_vhost/Makefile > +++ b/lib/librte_vhost/Makefile > @@ -44,10 +44,12 @@ CFLAGS += -I vhost_user > else > CFLAGS += -I vhost_cuse -lfuse > LDFLAGS += -lfuse > +LDLIBS += -lfuse > endif > > ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y) > LDFLAGS += -lnuma > +LDLIBS += -lnuma > endif It looks weird to have to declare the dependencies both in LDFLAGS and LDLIBS. What is the reason? Can we improve it?