From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roger B Melton <rmelton@cisco.com>
Subject: Re: [dpdk-stable] [PATCH] net/ixgbe: fix calling null
	function of VF
Date: Wed, 10 May 2017 15:08:59 -0400
Message-ID: <339650e6-40ea-b801-2c0a-6994038a6487@cisco.com>
References: <1494399602-33955-1-git-send-email-wei.dai@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Wei Dai <wei.dai@intel.com>, wenzhuo.lu@intel.com,
 konstantin.ananyev@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79])
 by dpdk.org (Postfix) with ESMTP id 58AA32BAA
 for <dev@dpdk.org>; Wed, 10 May 2017 21:09:00 +0200 (CEST)
In-Reply-To: <1494399602-33955-1-git-send-email-wei.dai@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-stable@dpdk.org per Thomas

I know this patch has already been applied but to complete the loop, I 
have applied the patch to 17.05-rc4 and verified within my application 
that the NULL function pointer issue for ixgbe_vf has been resolved.


Regards,
Roger

On 5/10/17 3:00 AM, Wei Dai wrote:
> hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not
> be called directly. It had better be replaced by calling
> ixgbe_get_media_type( ) to avoid crash.
>
> Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Dai <wei.dai@intel.com>
Tested-by Roger B Melton <rmelton@cisco.com>
> ---
>   drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ec667d8..ed2baec 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3799,7 +3799,7 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)
>   	hw->mac.get_link_status = true;
>   
>   	if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) &&
> -		hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) {
> +		ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {
>   		speed = hw->phy.autoneg_advertised;
>   		if (!speed)
>   			ixgbe_get_link_capabilities(hw, &speed, &autoneg);